Add diag kind to /detailed_diagnostic response

ycm-core · Nov 5, 2023 · 90f85b5 · 90f85b5
1 parent 62cfc45
commit 90f85b5
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/ycmd/completers/language_server/language_server_completer.py b/ycmd/completers/language_server/language_server_completer.py
@@ -1670,6 +1670,12 @@ def GetDetailedDiagnostic( self, request_data ):
       distance = _DistanceOfPointToRange( point, diagnostic[ 'range' ] )
       if minimum_distance is None or distance < minimum_distance:
         message = diagnostic[ 'message' ]
+        try:
+          code = diagnostic[ 'code' ]
+          message += f' [{ code }]'
+        except KeyError:
+          pass
+
         if distance == 0:
           break
         minimum_distance = distance

diff --git a/ycmd/tests/go/diagnostics_test.py b/ycmd/tests/go/diagnostics_test.py
@@ -74,7 +74,8 @@ def test_Diagnostics_DetailedDiags( self, app ):
                  any_of( has_entry( 'message',
                                     'undeclared name: diagnostics_test' ),
                          has_entry( 'message',
-                                    'undefined: diagnostics_test' ) ) )
+                                    'undefined: diagnostics_test'
+                                    ' [UndeclaredName]' ) ) )
 
 
   @WithRetry()

diff --git a/ycmd/tests/java/diagnostics_test.py b/ycmd/tests/java/diagnostics_test.py
@@ -301,7 +301,8 @@ def test_Diagnostics_DetailedDiags( self, app ):
     results = app.post_json( '/detailed_diagnostic', request_data ).json
     assert_that( results, has_entry(
         'message',
-        'The value of the field TestFactory.Bar.testString is not used' ) )
+        'The value of the field TestFactory.Bar.testString '
+        'is not used [570425421]' ) )
 
 
   @WithRetry()

diff --git a/ycmd/tests/rust/diagnostics_test.py b/ycmd/tests/rust/diagnostics_test.py
@@ -79,7 +79,7 @@ def test_Diagnostics_DetailedDiags( self, app ):
     results = app.post_json( '/detailed_diagnostic', request_data ).json
     assert_that( results, has_entry(
         'message',
-        'no field `build_` on type `test::Builder`\nunknown field' ) )
+        'no field `build_` on type `test::Builder`\nunknown field [E0609]' ) )
 
 
   @WithRetry()