Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Re-instate actually updating the server on file ready to parse
Perversely, in LSP completer, OnFileReadyToParse never parsed anything. At least, not in the obvious way. The original bug where we were doing redundant updates, ironically, was ensuring that we (eventually) updated the server with file contents (at some point in time) when we get OnFileReadyToParse. But by fixing that, we now never actually used the data supplied in OnFileReadyToParse, which the tests were relying heavily on. In particular, the Java tests would update file contents using only OnFileReadyToParse, which is a completely legitimate thing to do in our API. And worked. Until it didn't. Now it does again - we explicitly update server file state in OnFileReadyToParse, which seems perfectly sensible.
- Loading branch information