fix: Fix translate and annotation

yanguoyu · Nov 5, 2023 · 7754ab7 · 7754ab7 · github-actions · Nov 5, 2023
1 parent f8d4e95
commit 7754ab7
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 11 deletions.
diff --git a/packages/neuron-ui/src/components/DataSetting/index.tsx b/packages/neuron-ui/src/components/DataSetting/index.tsx
@@ -65,11 +65,12 @@ const DataSetting = () => {
     }
   }, [prevPath])
   const isLightClient = network?.type === LIGHT_NETWORK_TYPE
+  const hiddenDataPath = isLightClient || !network?.readonly
   return (
     <>
       <div className={styles.root}>
         <div className={styles.leftContainer}>
-          {isLightClient || !network?.readonly ? null : (
+          {hiddenDataPath ? null : (
             <div className={styles.label}>
               <div>{t('settings.data.ckb-node-data')}</div>
               <Tooltip
@@ -95,9 +96,7 @@ const DataSetting = () => {
           </div>
         </div>
         <div className={styles.rightContainer}>
-          {isLightClient || !network?.readonly ? null : (
-            <PathItem path={prevPath} openPath={openPath} handleClick={onSetting} />
-          )}
+          {hiddenDataPath ? null : <PathItem path={prevPath} openPath={openPath} handleClick={onSetting} />}
           <ClearCache
             className={styles.item}
             btnClassName={styles.itemBtn}

diff --git a/packages/neuron-ui/src/locales/en.json b/packages/neuron-ui/src/locales/en.json
@@ -1143,8 +1143,8 @@
     "main": {
       "external-node-detected-dialog": {
         "title": "External node detected",
-        "body-tips-without-network": "You selected an internal node, but activated an external node. If you need to continue using external nodes, please add a new network.",
-        "body-tips-with-network": "You have currently selected an internal node, but have activated an external node. If you need to continue using external nodes, please switch to another external network or add a new network.",
+        "body-tips-without-network": "\"Internal node\" is reserved for the built-in CKB node, please add a new network option for the external node.",
+        "body-tips-with-network": "\"Internal Node\" is reserved for the built-in CKB node, please select from the following network options or add a new one for the external node.",
         "add-network": "Add Network"
       }
     }

diff --git a/packages/neuron-ui/src/locales/zh-tw.json b/packages/neuron-ui/src/locales/zh-tw.json
@@ -1114,8 +1114,8 @@
     "main": {
       "external-node-detected-dialog": {
         "title": "檢測到外部節點",
-        "body-tips-without-network": "您選擇了內部節點，但啟動了外部節點。如果您需要繼續使用外部節點，請添加壹個新網絡。",
-        "body-tips-with-network": "您目前選擇了內部節點，但啟動了外部節點。如果您需要繼續使用外部節點，請切換到另壹個外部網絡或添加壹個新網絡。",
+        "body-tips-without-network": "\"Internal Node\" 僅用於連接內置節點，請添加新的網絡選項以連接外部節點。",
+        "body-tips-with-network": "\"Internal Node\" 僅用於連接內置節點，請從選擇以下網絡選項或添加新的網絡選項以連接外部節點。",
         "add-network": "添加網絡"
       }
     }

diff --git a/packages/neuron-ui/src/locales/zh.json b/packages/neuron-ui/src/locales/zh.json
@@ -1135,8 +1135,8 @@
     "main": {
       "external-node-detected-dialog": {
         "title": "检测到外部节点",
-        "body-tips-without-network": "您选择了内部节点，但启动了外部节点。如果您需要继续使用外部节点，请添加一个新网络。",
-        "body-tips-with-network": "您目前选择了内部节点，但启动了外部节点。如果您需要继续使用外部节点，请切换到另一个外部网络或添加一个新网络。",
+        "body-tips-without-network": "\"Internal Node\" 仅用于连接内置节点，请添加新的网络选项以连接外部节点。",
+        "body-tips-with-network": "\"Internal Node\" 仅用于连接内置节点，请从选择以下网络选项或添加新的网络选项以连接外部节点。",
         "add-network": "添加网络"
       }
     }

diff --git a/packages/neuron-wallet/src/services/networks.ts b/packages/neuron-wallet/src/services/networks.ts
@@ -145,7 +145,7 @@ export default class NetworksService extends Store {
 
     Object.assign(network, options)
     if (!network.readonly) {
-      // readonly network chaininfo can not update auto
+      // readonly network chaininfo is immutable
       Object.assign(
         network,
         await CommonUtils.timeout(2000, this.refreshChainInfo(network), network).catch(() => network)