Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suport for TMS tiles #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add suport for TMS tiles #2

wants to merge 2 commits into from

Conversation

tagorecaue
Copy link

Hi @atd-schubert can you publish at NPM today? I really need to use this and I'm having troubles with TypeScript in my machine

@atd-schubert
Copy link
Member

Here also, I can take a look at it in the evening. But there seems to be an error in the CI. Should I fix it directly, or should I request changes from you?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 91.131%

Files with Coverage Reduction New Missed Lines %
lib/tile-cache.js 6 84.48%
Totals Coverage Status
Change from base Build 5: -0.7%
Covered Lines: 259
Relevant Lines: 274

💛 - Coveralls

Copy link
Member

@atd-schubert atd-schubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for @yaga/tile-utils and apply version number to the package.json of this package

const start = Date.now();
const list: ITileCoordinates[] = getListOfTilesInBBox(bbox, maxZ, minZ);
const list: ITileCoordinates[] = getListOfTilesInBBox(bbox, maxZ, minZ, tms);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also specify the new version of @yaga/tile-utils, that includes tms support in the package.json.

For that, you have to apply the changes according to my requests in this PR. I will merge it as soon as possible and give you a new version number of tile-utils for this release. I think it will be 1.1.0...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants