Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-22814: Dashboard buttons layout is broken when there's a warning message #3835

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Jan 24, 2025

Jira URL

https://jira.xwiki.org/browse/XWIKI-22814

Changes

Description

  • Fixed the layout construction to make sure everything is fine if there's a warning box.
  • Removed typos

Clarifications

  • Instead of placing the buttons after the warning message if there's one, we should have placed their container. Should have been done when adding this container in XWIKI-11043.

Screenshots & Video

Before the PR:
image

After the PR:
Screenshot from 2025-01-24 11-15-32
image

Screenshot from 2025-01-24 11-15-09

Executed Tests

Successfully built the changes with mvn clean install -f xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war -Pquality.
Manual tests as seen in the screenshots above.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • 16.10.X

…a warning message

* Fixed the layout construction to make sure everything is fine if there's a warning box.
* Removed typos
@Sereza7 Sereza7 requested a review from michitux January 24, 2025 10:47
@michitux michitux merged commit 023144d into xwiki:master Jan 24, 2025
1 check passed
github-actions bot pushed a commit that referenced this pull request Jan 24, 2025
…a warning message (#3835)

* Fixed the layout construction to make sure everything is fine if there's a warning box.
* Removed typos

(cherry picked from commit 023144d)
Copy link

💚 All backports created successfully

Status Branch Result
stable-16.10.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

michitux pushed a commit that referenced this pull request Jan 24, 2025
…a warning message (#3835)

* Fixed the layout construction to make sure everything is fine if there's a warning box.
* Removed typos

(cherry picked from commit 023144d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants