XWIKI-21633: Adding a step tour on a class field doesn't work #3781
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added a hint for the element field of the step creation/edition forms. * Added a javascript log when the retrieval of the tour's JSON fails * Removed XWiki interpretation from the JSON construction velocity template in TourJson * Added the english value for the `element` field hint.
surli
reviewed
Jan 7, 2025
| @@ -428,7 +428,10 @@ require(['jquery', 'xwiki-meta'], function ($, xm) { | |||
| createTour(tour); | |||
| } | |||
| } | |||
| }).fail(function (data) { | |||
| console.log("Querying the JSON for the Tour failed. %o", data); | |||
surli
reviewed
Jan 7, 2025
| @@ -69,6 +69,8 @@ tour.popover.show.hint=You can restart the tour by clicking this button at anyti | |||
| # Steps | |||
| TourCode.StepClass_order=Order | |||
| TourCode.StepClass_element=Element (CSS selector that identify an element) | |||
| TourCode.StepClass_element.hint=CSS selector that identifies an element. Escape special CSS characters with a | |||
|
You said:
It's not entirely clear to me: you didn't actually performed any changes to add the backslashes. I assume you mean those still need to be put manually but the only change is on step 4: now those are not transformed anymore to \n? is that correct? So if I understand properly your changes don't fix using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21633
Changes
Description
elementfield hint.Clarifications
\\\newlinesyntax and replaces it with\nelementfield so that it's easier to use by adminsScreenshots & Video
Both of those screenshots are taken after applying the changes proposed in this PR:
Executed Tests
Successfully passed
mvn clean install -f xwiki-platform-core/xwiki-platform-tour/ -Pquality,integration-tests,docker -Dxwiki.test.ui.wcag=truewith no WCAG warning.Expected merging strategy