Fix gitmkdtemp: correct test for mktemp() return value

In gitmkdtemp, the return value of mktemp is not tested correctly. mktemp() always returns its 'template' argument, even upon failure. An error is signalled by making the template an empty string. Signed-off-by: Filippo Negroni <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
xu-kai-xu · Feb 25, 2010 · 1f80c2a · 1f80c2a
1 parent 0606c36
commit 1f80c2a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/compat/mkdtemp.c b/compat/mkdtemp.c
@@ -2,7 +2,7 @@
 
 char *gitmkdtemp(char *template)
 {
-	if (!mktemp(template) || mkdir(template, 0700))
+	if (!*mktemp(template) || mkdir(template, 0700))
 		return NULL;
 	return template;
 }