Keep a debug log in case we are not able to get the token

xrmx · Dec 23, 2024 · 1462091 · 1462091
1 parent 0eba358
commit 1462091
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/...nsion/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/resource/ec2.py b/...nsion/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/resource/ec2.py
@@ -84,7 +84,12 @@ def detect(self) -> "Resource":
             # If can't get a token quick assume we are not on ec2
             try:
                 token = _get_token(timeout=1)
-            except URLError:
+            except URLError as exception:
+                logger.debug(
+                    "%s failed to get token: %s",
+                    self.__class__.__name__,
+                    exception,
+                )
                 return Resource.get_empty()
 
             identity_dict = json.loads(_get_identity(token))

diff --git a/sdk-extension/opentelemetry-sdk-extension-aws/tests/resource/test_ec2.py b/sdk-extension/opentelemetry-sdk-extension-aws/tests/resource/test_ec2.py
@@ -82,5 +82,14 @@ def test_simple_create(
     def test_empty_resource_if_token_returns_an_url_error(
         self, mock_get_token
     ):
-        actual = AwsEc2ResourceDetector().detect()
+        with self.assertLogs(
+            "opentelemetry.sdk.extension.aws.resource.ec2", level="DEBUG"
+        ) as logger:
+            actual = AwsEc2ResourceDetector().detect()
+            self.assertEqual(
+                logger.output,
+                [
+                    "DEBUG:opentelemetry.sdk.extension.aws.resource.ec2:AwsEc2ResourceDetector failed to get token: <urlopen error Something went wrong>"
+                ],
+            )
         self.assertDictEqual(actual.attributes.copy(), OrderedDict())