Don't use pointer to interface

[mkysel]

Minor fix. Interfaces can be nil, so there is no need for the extra pointer to interface.

Summary by CodeRabbit

• Refactor
  • Improved the backend service initialization by streamlining how internal parameters are handled, enhancing maintainability while keeping the same functionality.
  • Simplified the instantiation of the service by removing an intermediate variable, resulting in cleaner code.

[coderabbitai]

Walkthrough

The pull request changes the parameter type of metadataApiClient in the NewPayerApiService function within pkg/api/payer/service.go. The parameter is now passed by value as MetadataApiClientConstructor instead of by pointer. The assignment inside the function is updated accordingly, while the error handling and overall service initialization remain unchanged. Additionally, the instantiation of payer.NewPayerApiService in pkg/api/payer/publish_test.go has been simplified by removing an intermediate variable.

Changes

File(s)	Change Summary
pkg/api/payer/service.go	Updated NewPayerApiService: parameter metadataApiClient changed from pointer (*MetadataApiClientConstructor) to value (MetadataApiClientConstructor); adjusted assignment without dereferencing.
pkg/api/payer/publish_test.go	Simplified instantiation of payer.NewPayerApiService by removing the intermediate variable interf and directly passing a new instance of FixedMetadataApiClientConstructor.

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a073f1 and bb556fb.

📒 Files selected for processing (1)

• pkg/api/payer/publish_test.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Test (Node)

🔇 Additional comments (1)

pkg/api/payer/publish_test.go (1)

84-86: LGTM! Code simplification aligns with PR objectives.

The direct instantiation of FixedMetadataApiClientConstructor improves code clarity by removing unnecessary indirection while maintaining the same functionality.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

pkg/api/payer/service.go (1)

44-44: LGTM! Good practice to avoid pointer to interface.

The change from *MetadataApiClientConstructor to MetadataApiClientConstructor is a good practice in Go. Since interfaces are already pointer-like types internally (containing both type info and data pointers), adding another level of indirection with a pointer is unnecessary. This change makes the code more idiomatic while maintaining the same functionality.

Consider applying the same pattern to other interface parameters in the codebase. For example, blockchainPublisher blockchain.IBlockchainPublisher is already following this pattern.

Also applies to: 51-51

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f260ccd and 0a073f1.

📒 Files selected for processing (1)

• pkg/api/payer/service.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Lint-Go