Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(solidity): trigger only on path #448

Merged
merged 1 commit into from
Feb 2, 2025
Merged

ci(solidity): trigger only on path #448

merged 1 commit into from
Feb 2, 2025

Conversation

fbac
Copy link
Collaborator

@fbac fbac commented Jan 31, 2025

Solidity CI was triggering when PR are pushed to main.

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflow configuration for Solidity to trigger based on specific path changes instead of branch-based triggering.
    • Maintained existing workflow jobs and steps without modifications.

@fbac fbac requested a review from a team as a code owner January 31, 2025 17:29
Copy link

coderabbitai bot commented Jan 31, 2025

Warning

Rate limit exceeded

@fbac has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 41 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 09ae609 and bf91423.

📒 Files selected for processing (1)
  • .github/workflows/solidity.yml (2 hunks)

Walkthrough

The pull request modifies the GitHub Actions workflow configuration for Solidity by changing the trigger conditions. Instead of triggering on pushes to the main branch, the workflow will now activate based on specific path changes, specifically within the contracts directory and the workflow file itself. This path-based triggering approach provides more granular control over workflow execution, ensuring that the Solidity-related jobs only run when relevant files are modified.

Changes

File Change Summary
.github/workflows/solidity.yml Modified workflow trigger conditions from branch-based to path-based, specifying triggers on changes in contracts/ directory and the workflow file

Suggested Reviewers

  • mkysel

Possibly Related PRs


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/solidity.yml (1)

5-7: LGTM! Path-based triggering improves CI efficiency.

The addition of path filters for push events is well-implemented:

  • Matches the existing pull_request trigger paths for consistency
  • Correctly includes both contract files and the workflow itself
  • Will reduce unnecessary CI runs by only triggering on relevant changes

This change will improve CI efficiency by:

  • Reducing resource usage
  • Decreasing pipeline queue times
  • Focusing builds on relevant changes only
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 96fa0da and 09ae609.

📒 Files selected for processing (1)
  • .github/workflows/solidity.yml (1 hunks)

@fbac fbac force-pushed the ci/solidity-path branch from 09ae609 to 693bf29 Compare January 31, 2025 17:39
@fbac fbac force-pushed the ci/solidity-path branch from 693bf29 to bf91423 Compare January 31, 2025 17:40
@fbac fbac merged commit 3b050f7 into main Feb 2, 2025
11 checks passed
@fbac fbac deleted the ci/solidity-path branch February 2, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants