Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Graphite MQ] Draft PR GROUP:c489ca (PRs 143) #146

Conversation

graphite-app[bot]
Copy link

@graphite-app graphite-app bot commented Sep 5, 2024

This draft PR was created by the Graphite merge queue.
Trunk will be fast forwarded to the HEAD of this PR when CI passes, and the original PRs will be closed.

The following PRs are included in this draft PR:

## tl;dr

- Adds `NodeRegistryAdmin` struct to handle administrative actions on the Nodes smart contract
- Makes it possible to deploy fresh smart contracts in tests, so we can execute against a clean contract state

## More info

We have one blockchain node shared in the test environment, but we are going to want to be able to write tests that run against the same smart contract without interfering with one another.

To handle that we now have a `deploy-ephemeral` script which will create a new instance of the smart contract at a new address. We can call that from inside tests to get a clean contract to test against.

I still have the first deployed contract being loaded from the `_build` folder, which is being used in some older tests. We may want to phase that out and just always work against clean smart contracts.
@graphite-app graphite-app bot closed this Sep 5, 2024
@graphite-app graphite-app bot deleted the gtmq_c489ca_143_1725570614409-20cbbb60-ec69-4699-9e4e-109782c602b7 branch September 5, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant