Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify port #117

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Unify port #117

merged 3 commits into from
Aug 29, 2024
+1 −2

Conversation

mkysel
Copy link
Collaborator

@mkysel mkysel commented Aug 26, 2024

Pre-PR we expose a different port than the docker image expects.

I picked 80 since it makes the most sense, but we can pick any other port if people have opinions.

neekolas
neekolas reviewed Aug 26, 2024
View reviewed changes
pkg/config/options.go Outdated Show resolved Hide resolved
@mkysel mkysel requested a review from neekolas August 29, 2024 15:05
@mkysel mkysel merged commit 70ce604 into main Aug 29, 2024
4 checks passed
@mkysel mkysel deleted the mkysel/unify-port branch August 29, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neekolas neekolas neekolas approved these changes

@richardhuaaa richardhuaaa Awaiting requested review from richardhuaaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkysel @neekolas