Setup golines checker #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardhuaaa
approved these changes
Aug 26, 2024
| @@ -9,29 +9,29 @@ type ApiOptions struct { | |||
| } | |||
|
|
|||
| type ContractsOptions struct { | |||
There was a problem hiding this comment.
Could optionally exclude this file/directory too, up to you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that CI catches files that have not been formatted by
golines.Add a script that does the formatting and ignores autogenerated files.
Both idea and vscode will reformat a generated file if you save it. Since golines does not offer a good way to ignore these files correctly.
Here is the CI detecting a poorly formatted file: https://github.com/xmtp/xmtpd/actions/runs/10564716546/job/29267709565