Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert client removal #593

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Revert client removal #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f254e1
add back the client to the conversation
nplasterer Jan 27, 2025
2998faa
Create eight-bugs-jump.md
nplasterer Jan 27, 2025
860f621
fix up the type script error
nplasterer Jan 27, 2025
e441518
Merge branch 'np/revert-client-removal' of https://github.com/xmtp/xm…
nplasterer Jan 27, 2025
472ba64
fix up the tests
nplasterer Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eight-bugs-jump.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@xmtp/react-native-sdk": patch
---

Revert client removal
4 changes: 2 additions & 2 deletions example/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ PODS:
- CSecp256k1 (~> 0.2)
- LibXMTP (= 3.0.20)
- SQLCipher (= 4.5.7)
- XMTPReactNative (3.1.8):
- XMTPReactNative (3.1.9):
- CSecp256k1 (~> 0.2)
- ExpoModulesCore
- MessagePacker
Expand Down Expand Up @@ -763,7 +763,7 @@ SPEC CHECKSUMS:
SQLCipher: 5e6bfb47323635c8b657b1b27d25c5f1baf63bf5
SwiftProtobuf: 4dbaffec76a39a8dc5da23b40af1a5dc01a4c02d
XMTP: 3d82fe8598fe043a67ad93276084ab46a30a1fa3
XMTPReactNative: f0b7d6a9314de5ba377cc5d3d89ecd896cd564d5
XMTPReactNative: 8758bb7d92ff8e6cf9a31cf0f57e5b09cc51319d
Yoga: e71803b4c1fff832ccf9b92541e00f9b873119b9

PODFILE CHECKSUM: 0e6fe50018f34e575d38dc6a1fdf1f99c9596cdd
Expand Down
4 changes: 2 additions & 2 deletions example/src/tests/dmTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ test('can filter dms by consent', async () => {
const boConvosFilteredAllowed = await boClient.conversations.listDms(
{},
undefined,
'allowed'
['allowed']
)
const boConvosFilteredUnknown = await boClient.conversations.listDms(
{},
undefined,
'unknown'
['unknown']
)

assert(
Expand Down
1 change: 1 addition & 0 deletions example/src/tests/groupPermissionsTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,6 +626,7 @@ test('creating a group with invalid permissions should fail', async () => {
updateGroupDescriptionPolicy: 'allow',
updateGroupImagePolicy: 'admin',
updateGroupPinnedFrameUrlPolicy: 'deny',
updateMessageExpirationPolicy: 'admin',
}

// Bo creates a group with Alix and Caro
Expand Down
12 changes: 6 additions & 6 deletions example/src/tests/groupTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,12 +178,12 @@ test('groups cannot fork', async () => {
const lastMessage = messages[0]
// console.log(lastMessage);
console.log(
`${receiverGroupToCheck.clientInstallationId} sees ${messages.length} messages in group`
`${receiverGroupToCheck.client.installationId} sees ${messages.length} messages in group`
)
assert(
lastMessage !== undefined &&
lastMessage.nativeContent.text === messageContent,
`${receiverGroupToCheck.clientInstallationId} should have received the message, FORK? ${lastMessage?.nativeContent.text} !== ${messageContent}`
`${receiverGroupToCheck.client.installationId} should have received the message, FORK? ${lastMessage?.nativeContent.text} !== ${messageContent}`
)
// }
}
Expand Down Expand Up @@ -297,12 +297,12 @@ test('groups cannot fork short version', async () => {
})
const lastMessage = messages[0]
console.log(
`${receiverGroup.clientInstallationId} sees ${messages.length} messages in group`
`${receiverGroup.client.installationId} sees ${messages.length} messages in group`
)
assert(
lastMessage !== undefined &&
lastMessage.nativeContent.text === messageContent,
`${receiverGroup.clientInstallationId} should have received the message, FORK? ${lastMessage?.nativeContent.text} !== ${messageContent}`
`${receiverGroup.client.installationId} should have received the message, FORK? ${lastMessage?.nativeContent.text} !== ${messageContent}`
)
}
// When forked, it stays forked even if we try 5 times
Expand Down Expand Up @@ -372,12 +372,12 @@ test('groups cannot fork short version - update metadata', async () => {
})
const lastMessage = messages[0]
console.log(
`${receiverGroup.clientInstallationId} sees ${messages.length} messages in group`
`${receiverGroup.client.installationId} sees ${messages.length} messages in group`
)
assert(
lastMessage !== undefined &&
lastMessage.nativeContent.text === messageContent,
`${receiverGroup.clientInstallationId} should have received the message, FORK? ${lastMessage?.nativeContent.text} !== ${messageContent}`
`${receiverGroup.client.installationId} should have received the message, FORK? ${lastMessage?.nativeContent.text} !== ${messageContent}`
)
}
// When forked, it stays forked even if we try 5 times
Expand Down
Loading
Loading