Merge branch 'coda/asyncless-transactions' of github.com:xmtp/libxmtp…

… into coda/asyncless-transactions

xmtp_mls/src/groups/mls_sync.rs

@@ -554,6 +554,7 @@ where
         if !matches!(result, Err(StorageError::IntentionalRollback)) {
             result?;
         }
+
         let processed_message = processed_message.expect("Was just set to Some")?;
 
         let (sender_inbox_id, sender_installation_id) =
@@ -600,6 +601,7 @@ where
 
         provider.transaction(|provider| {
             let processed_message = mls_group.process_message(provider, message)?;
+
             let mut validated_commit = None;
 
             if let ProcessedMessageContent::StagedCommitMessage(staged_commit) =

xmtp_mls/src/groups/validated_commit.rs

@@ -290,13 +290,12 @@ impl ValidatedCommit {
         let group_permissions: GroupMutablePermissions = extensions.try_into()?;
         let current_group_members = get_current_group_members(openmls_group);
 
-        let existing_group_extensions = openmls_group.extensions();
         let new_group_extensions = staged_commit.group_context().extensions();
 
         let metadata_changes = extract_metadata_changes(
             &immutable_metadata,
             &mutable_metadata,
-            existing_group_extensions,
+            extensions,
             new_group_extensions,
         )?;
 
@@ -507,7 +506,7 @@ fn get_latest_group_membership(
     extract_group_membership(staged_commit.group_context().extensions())
 }
 
-pub(super) struct ExpectedDiff {
+pub struct ExpectedDiff {
     new_group_membership: GroupMembership,
     expected_installation_diff: InstallationDiff,
     added_inboxes: Vec<Inbox>,