added omitempty to enabled bool to avoid accidental overwriting

xigxog · May 22, 2024 · 7afcba7 · 7afcba7
1 parent e5966f3
commit 7afcba7
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/api/crds/kubefox.xigxog.io_platforms.yaml b/api/crds/kubefox.xigxog.io_platforms.yaml
@@ -4789,10 +4789,7 @@ spec:
                       address:
                         type: string
                       enabled:
-                        default: false
                         type: boolean
-                    required:
-                    - enabled
                     type: object
                   logs:
                     properties:

diff --git a/api/kubernetes/types.go b/api/kubernetes/types.go
@@ -100,8 +100,7 @@ type TelemetrySpec struct {
 }
 
 type CollectorSpec struct {
-	// +kubebuilder:default=false
-	Enabled bool   `json:"enabled"`
+	Enabled bool   `json:"enabled,omitempty"`
 	Address string `json:"address,omitempty"`
 }
 

diff --git a/docs/reference/kubernetes-crds.md b/docs/reference/kubernetes-crds.md
@@ -294,7 +294,7 @@ Used by:<br>
 
 | Field | Type | Description | Validation |
 | ----- | ---- | ----------- | ---------- |
-| `enabled` | <div style="white-space:nowrap">boolean<div> | <div style="max-width:30rem"></div> | <div style="white-space:nowrap">default: false</div> |
+| `enabled` | <div style="white-space:nowrap">boolean<div> | <div style="max-width:30rem"></div> | <div style="white-space:nowrap"></div> |
 | `address` | <div style="white-space:nowrap">string<div> | <div style="max-width:30rem"></div> | <div style="white-space:nowrap"></div> |