opt: remove code smell

for loop should avoid change the iterators
xiaoyifang · Aug 10, 2024 · 0fedfba · 0fedfba
1 parent c29698e
commit 0fedfba
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/article_maker.cc b/src/article_maker.cc
@@ -285,9 +285,9 @@ sptr< Dictionary::DataRequest > ArticleMaker::makeDefinitionFor( QString const &
     std::vector< sptr< Dictionary::Class > > dicts;
 
     // Find dictionaries by ID's
-    for ( QStringList::Iterator it = dictIDs.begin(); it != dictIDs.end(); ++it ) {
+    for ( const auto & dictId : dictIDs ) {
       for ( unsigned x = 0; x < dictionaries.size(); x++ ) {
-        if ( *it == QString::fromStdString( dictionaries[ x ]->getId() ) ) {
+        if ( dictId == QString::fromStdString( dictionaries[ x ]->getId() ) ) {
           dicts.push_back( dictionaries[ x ] );
           break;
         }