Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New isDirty aliases. #3915

Merged
merged 2 commits into from
Feb 4, 2025
Merged

New isDirty aliases. #3915

merged 2 commits into from
Feb 4, 2025

Conversation

lbwexler
Copy link
Member

@lbwexler lbwexler commented Feb 2, 2025

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@lbwexler lbwexler linked an issue Feb 2, 2025 that may be closed by this pull request
@lbwexler lbwexler requested a review from amcclain February 2, 2025 19:06
Copy link
Contributor

@PeteDarinzo PeteDarinzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved.

@lbwexler lbwexler merged commit 072f825 into develop Feb 4, 2025
2 checks passed
@lbwexler lbwexler deleted the isDirty branch February 4, 2025 16:49
@amcclain
Copy link
Member

amcclain commented Feb 4, 2025

Thank you much for this guys, was on my list to review this morning but you (happily) beat me to it. Great that we covered all the cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alias Store.isModified as Store.isDirty
3 participants