Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Path Search Panel component (for Admin Use) #3911

Merged
merged 22 commits into from
Jan 30, 2025
Merged

JSON Path Search Panel component (for Admin Use) #3911

merged 22 commits into from
Jan 30, 2025

Conversation

cnrudd
Copy link
Member

@cnrudd cnrudd commented Jan 24, 2025

Pair with Hoist Core PR: xh/hoist-core#439

(Requires a Hoist Core release with that PR merged to work, but otherwise not a breaking change)

Code still needs Changelog entry. But UX experience is good to review.

Docs for json-path and json-patch libs used:

https://github.com/java-json-tools/json-patch
https://github.com/json-path/JsonPath

JSON Patch Standards Docs: https://jsonpatch.com/
JSON Path Standards Docs: https://goessner.net/articles/JsonPath/
JSON Patch RFC: https://datatracker.ietf.org/doc/html/rfc6902

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes: no breaking changes
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile: not required
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

CHANGELOG.md Show resolved Hide resolved
Copy link
Member

@amcclain amcclain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great from my perspective - will leave for @lbwexler in case any additional thoughts or polish before merge.

Really nice new feature and nicely packaged for merge, thank you!

# Conflicts:
#	CHANGELOG.md
@lbwexler lbwexler merged commit f8d655b into develop Jan 30, 2025
2 checks passed
@lbwexler lbwexler deleted the jsonPath branch January 30, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants