Code

Hoist dialog model#1714

Code

Closed

cnrudd wants to merge 96 commits intodevelopxh/hoist-react:developfrom hoistDialogModelxh/hoist-react:hoistDialogModelCopy head branch name to clipboard

+2,189-1,087

Commits

Commits on Dec 26, 2019

• First cut of hoist dialog with isDraggable option.

  cnrudd

  committed
  471594f

  Copy full SHA for 471594f

• Removed unused imports.

  cnrudd

  committed
  7da244f

  Copy full SHA for 7da244f

Commits on Dec 27, 2019

• Added canMaskClickClose prop and maskClick handler

  cnrudd

  committed
  2bab03f

  Copy full SHA for 2bab03f

• Fix maskclick handler

  cnrudd

  committed
  8a90e0f

  Copy full SHA for 8a90e0f

• added todo

  cnrudd

  committed
  ec01ac3

  Copy full SHA for ec01ac3

Commits on Jan 2, 2020

• Support autoFocus: true on dialog children

  cnrudd

  committed
  73ccc65

  Copy full SHA for 73ccc65

Commits on Jan 3, 2020

• Replaced react-draggable with react-rnd, which uses react-draggable.

  cnrudd

  committed
  107c490

  Copy full SHA for 107c490

• Added --xh-dialog-box-shadow

  cnrudd

  committed
  90f5f42

  Copy full SHA for 90f5f42

• Support for resizing

  cnrudd

  committed
  d6650a3

  Copy full SHA for d6650a3

Commits on Jan 6, 2020

• Fix repaint bug

  cnrudd

  committed
  9a7f05b

  Copy full SHA for 9a7f05b

• Remove redundant use of splitLayoutProps

  cnrudd

  committed
  b3fe561

  Copy full SHA for b3fe561

• Remove bug comment and fix. Bug existed only on chrome 78.3x . Upgrading to chrome v79 fixed the issue.

  cnrudd

  committed
  2a65a78

  Copy full SHA for 2a65a78

• Refactored with elementfactory.

  cnrudd

  committed
  c8f401b

  Copy full SHA for c8f401b

• Remove need for constructor.

  cnrudd

  committed
  8e347e3

  Copy full SHA for 8e347e3

Commits on Jan 7, 2020

• Converted Dialog from class comp to function comp.

  cnrudd

  committed
  3af10ed

  Copy full SHA for 3af10ed

• Support resizable config

  cnrudd

  committed
  a3b640b

  Copy full SHA for a3b640b

• Refactor, with dialogHeader impl

  cnrudd

  committed
  d583d76

  Copy full SHA for d583d76

Commits on Jan 8, 2020

• Linting.

  cnrudd

  committed
  fad1660

  Copy full SHA for fad1660

• Let dialogs autocenter based on content dimensions;

  Show description for 88b0d45
  cnrudd

  committed
  88b0d45

  Copy full SHA for 88b0d45

Commits on Jan 14, 2020

• Use given width and height props if resizeable

  cnrudd

  committed
  c06514e

  Copy full SHA for c06514e

• throw if no dims props with resizable = true

  cnrudd

  committed
  42a4d00

  Copy full SHA for 42a4d00

• Add Maximize Minimize toggle if resizable.

  cnrudd

  committed
  d7d7a10

  Copy full SHA for d7d7a10

Commits on Jan 17, 2020

• Implemented localstorage statemodel on dialog.

  cnrudd

  committed
  41c129c

  Copy full SHA for 41c129c

• Improve handling of 0 position values.

  cnrudd

  committed
  cfaa2af

  Copy full SHA for cfaa2af

Commits on Jan 18, 2020

• Improve safe state loading on dialog.

  cnrudd

  committed
  e3169c1

  Copy full SHA for e3169c1

• Remove unnecessary setting of defaults on RnD, fix unMaximize.

  cnrudd

  committed
  1d57410

  Copy full SHA for 1d57410

• Support x, y props.

  cnrudd

  committed
  21f9f5d

  Copy full SHA for 21f9f5d

Commits on Jan 21, 2020

• Merge branch 'develop' into hoistDialog

  cnrudd

  committed
  10f08c2

  Copy full SHA for 10f08c2

• Merge branch 'develop' into hoistDialog

  cnrudd

  committed
  40c27b5

  Copy full SHA for 40c27b5

Commits on Jan 23, 2020

• Cleanup setState on render logic

  cnrudd

  committed
  28c1175

  Copy full SHA for 28c1175

Commits on Feb 2, 2020

• Unifiied dialog sub component with mask and closeOnOutsideClick props.

  cnrudd

  committed
  ffb7b14

  Copy full SHA for ffb7b14

Commits on Feb 9, 2020

• added --xh-dialog-box-shadow

  cnrudd

  authored
  f320af6

  Copy full SHA for f320af6

• Support style passthrough and zIndex prop

  cnrudd

  committed
  34475a7

  Copy full SHA for 34475a7

• Merge branch 'hoistDialog' of github.com:exhi/hoist-react into hoistDialog

  cnrudd

  committed
  07fb4bb

  Copy full SHA for 07fb4bb

• --xh-dialog-box-shadow dark theme

  cnrudd

  authored
  4c38c76

  Copy full SHA for 4c38c76

Commits on Feb 10, 2020

• Improve takeup of style & zIndex & rndoptions

  cnrudd

  committed
  321de51

  Copy full SHA for 321de51

Commits on Feb 15, 2020

• Cleanup prop and model passing.

  cnrudd

  committed
  2f934ec

  Copy full SHA for 2f934ec

• Remove unused zIndex

  cnrudd

  committed
  cf7e6c4

  Copy full SHA for cf7e6c4

• Support static base zindex for all dialogs

  cnrudd

  committed
  b2bdf02

  Copy full SHA for b2bdf02

Commits on Feb 16, 2020

• Better method name: calcPos -> calcCenteredPos.

  cnrudd

  committed
  4753e87

  Copy full SHA for 4753e87

• React-rnd semver tweak.

  cnrudd

  committed
  cc5a41c

  Copy full SHA for cc5a41c

• Put scss var decl on one line.

  cnrudd

  committed
  633563b

  Copy full SHA for 633563b

• Merge branch 'develop' into hoistDialog

  cnrudd

  committed
  8ed6342

  Copy full SHA for 8ed6342

• Latest deps in yarn.lock

  cnrudd

  committed
  ea94ab1

  Copy full SHA for ea94ab1

• Model passing cleanup.

  cnrudd

  committed
  8b8283a

  Copy full SHA for 8b8283a

• Fix setPositionState

  cnrudd

  committed
  372a8c7

  Copy full SHA for 372a8c7

Commits on Feb 17, 2020

• Move showCloseButton to prop

  cnrudd

  committed
  65816e0

  Copy full SHA for 65816e0

Commits on Feb 18, 2020

• Rework as controlled component;

  Show description for 7e6d049
  cnrudd

  committed
  7e6d049

  Copy full SHA for 7e6d049

Commits on Feb 19, 2020

• Fix closeOnEscape handling

  cnrudd

  committed
  9ac3175

  Copy full SHA for 9ac3175

• convert closeOnEscape to prop

  cnrudd

  committed
  ede3e35

  Copy full SHA for ede3e35

Commits on Feb 21, 2020

• Fix handling of specified size and width when not resizable.

  cnrudd

  committed
  3fdf152

  Copy full SHA for 3fdf152

• Merge branch 'develop' into hoistDialog

  cnrudd

  committed
  5f5c8b8

  Copy full SHA for 5f5c8b8

• Use Hoist Dialog for messages.

  cnrudd

  committed
  272a2b0

  Copy full SHA for 272a2b0

• Match dialog styles to current hoist/bp dialog styles.

  cnrudd

  committed
  3d7d0c8

  Copy full SHA for 3d7d0c8

• Lee and Colin: codev

  lbwexler

  committed
  b10b57e

  Copy full SHA for b10b57e

Commits on Feb 24, 2020

• WIP

  cnrudd

  committed
  31df902

  Copy full SHA for 31df902

• Use elementFromContent for the dialog content.

  cnrudd

  committed
  aa32bf8

  Copy full SHA for aa32bf8

• Get setting off model, not prop.

  cnrudd

  committed
  839bbf5

  Copy full SHA for 839bbf5

Commits on Feb 25, 2020

• Remove body overflow switch

  cnrudd

  committed
  2f5add3

  Copy full SHA for 2f5add3

• No longer allow create model from default.

  cnrudd

  committed
  8207761

  Copy full SHA for 8207761

• Remove portal div from DOM when popup closes

  cnrudd

  committed
  482af25

  Copy full SHA for 482af25

• use Hoist Dialog on Message components.

  cnrudd

  committed
  f8087c5

  Copy full SHA for f8087c5

• ClientErrorDetail dialog uses Hoist Dialog.

  cnrudd

  committed
  573ad4f

  Copy full SHA for 573ad4f

• Keep centered dialogs centered on window resize.

  cnrudd

  committed
  2a56b6e

  Copy full SHA for 2a56b6e

• Add inPortal switch

  cnrudd

  committed
  02e69ec

  Copy full SHA for 02e69ec

• Cleanup

  cnrudd

  committed
  15df57f

  Copy full SHA for 15df57f

• Merge branch 'develop' into hoistDialogModel

  cnrudd

  committed
  ce58b7e

  Copy full SHA for ce58b7e

Commits on Mar 4, 2020

• Changes to positioning to better handle observable positions and sizes.

  cnrudd

  committed
  b3fc861

  Copy full SHA for b3fc861

• Merge branch 'develop' into hoistDialogModel

  cnrudd

  committed
  95a5217

  Copy full SHA for 95a5217

• Better use of computed and observables for position and sizing.

  cnrudd

  committed
  d8d7f2b

  Copy full SHA for d8d7f2b

Commits on Mar 5, 2020

• Fix some state model edge cases.

  cnrudd

  committed
  5e75e54

  Copy full SHA for 5e75e54

• Working observables!

  cnrudd

  committed
  bd54225

  Copy full SHA for bd54225

• Make maximized dialog resize with body when body resizes.

  cnrudd

  committed
  026ce7e

  Copy full SHA for 026ce7e

Commits on Mar 16, 2020

• Merge branch 'develop' into hoistDialogModel

  cnrudd

  committed
  3a44217

  Copy full SHA for 3a44217

• Fix maximize in non-portal dialog

  cnrudd

  committed
  c4a5aec

  Copy full SHA for c4a5aec

• Use initialX|Y|Width|Height

  cnrudd

  committed
  4d8fca3

  Copy full SHA for 4d8fca3

• Use currentHeight|Width in sizing dialog content

  cnrudd

  committed
  014ef1e

  Copy full SHA for 014ef1e

• Refactor pos and size functionality.

  cnrudd

  committed
  9ccb92f

  Copy full SHA for 9ccb92f

• Enforce x,y & width,height set together.

  cnrudd

  committed
  e2f315b

  Copy full SHA for e2f315b

• Prevent draghandles when maximized

  cnrudd

  committed
  86075b2

  Copy full SHA for 86075b2

• todo reminder

  cnrudd

  committed
  378b189

  Copy full SHA for 378b189

• Name cleanups.

  cnrudd

  committed
  7c7efde

  Copy full SHA for 7c7efde

Commits on Mar 17, 2020

• Move non-public methods to implementation section.

  cnrudd

  committed
  5e60c71

  Copy full SHA for 5e60c71

Commits on Mar 22, 2020

• Replace .bp3_dailog default css width of 500px with content width

  cnrudd

  committed
  405df39

  Copy full SHA for 405df39

• Put width setting on content, not on dialog.

  cnrudd

  committed
  35c2d6f

  Copy full SHA for 35c2d6f

Commits on Mar 23, 2020

• Specify width on ClientError dialog, and make resizable.

  cnrudd

  committed
  c6a1596

  Copy full SHA for c6a1596

• Better content rendering via css: avoid background -color bleed with display:flex

  cnrudd

  committed
  b127522

  Copy full SHA for b127522

• Now that dialog is resizable, make jsoninput 100% height

  cnrudd

  committed
  91d1537

  Copy full SHA for 91d1537

• Put width spec on Dialog, not on content.

  cnrudd

  committed
  36c2520

  Copy full SHA for 36c2520

• New MenuButton component

  cnrudd

  committed
  62f631d

  Copy full SHA for 62f631d

• Support resizable with no width & height, or just one dim. Also support just one dim if resizable = false;

  cnrudd

  committed
  e99536a

  Copy full SHA for e99536a

Commits on Mar 26, 2020

• Merge branch 'develop' into hoistDialogModel

  Show description for 46ee943
  lbwexler

  committed
  46ee943

  Copy full SHA for 46ee943

• Merge remote-tracking branch 'origin/hoistDialogModel' into hoistDialogModel

  Show description for c163282
  lbwexler

  committed
  c163282

  Copy full SHA for c163282

• + Pass model with Context.

  Show description for 5492d18
  lbwexler

  committed
  5492d18

  Copy full SHA for 5492d18

• + Use LocalModel pattern

  Show description for 76883e7
  lbwexler

  committed
  76883e7

  Copy full SHA for 76883e7

• Rework of menubutton to splitbutton

  cnrudd

  committed
  8221aa1

  Copy full SHA for 8221aa1