Fixed bug where check grid details were occasionally stale

xh · Jan 2, 2025 · 569986a · 569986a
1 parent 8dadd9b
commit 569986a
Showing 1 changed file with 11 additions and 13 deletions.
diff --git a/admin/tabs/cluster/distobjects/DistributedObjectsModel.ts b/admin/tabs/cluster/distobjects/DistributedObjectsModel.ts
@@ -294,19 +294,17 @@ export class DistributedObjectsModel extends HoistModel {
             ),
             {selectedId} = this.detailGridModel ?? {};
 
-        // Only re-create grid model if columns are different.
-        if (!oldRecord || !isEqual(oldRecord.data.comparisonFields, comparisonFields)) {
-            XH.safeDestroy(this.detailGridModel);
-            const createColumnForField = fieldName => ({
-                field: {name: fieldName, displayName: fieldName},
-                renderer: v => (typeof v === 'object' ? JSON.stringify(v) : v),
-                autosizeMaxWidth: 200
-            });
-            this.detailGridModel = this.createDetailGridModel(
-                comparisonFields.map(createColumnForField),
-                nonComparisonFields.map(createColumnForField)
-            );
-        }
+        // Always re-create the grid model, as its not trivial to check if columns have changed.
+        XH.safeDestroy(this.detailGridModel);
+        const createColumnForField = fieldName => ({
+            field: {name: fieldName, displayName: fieldName},
+            renderer: v => (typeof v === 'object' ? JSON.stringify(v) : v),
+            autosizeMaxWidth: 200
+        });
+        this.detailGridModel = this.createDetailGridModel(
+            comparisonFields.map(createColumnForField),
+            nonComparisonFields.map(createColumnForField)
+        );
 
         this.detailGridModel.loadData(
             instanceNames.map(instanceName => {