Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar accessibility and desktop bottom margin #311

Merged
merged 8 commits into from
Feb 2, 2025

Conversation

dkackman
Copy link
Contributor

This PR fixes #286 and also adds some accessibility attributes to header, layout and nav.

The bottom margin fix apply pb-4 to the BottomNav in header.tsx when not on mobile.

@dkackman
Copy link
Contributor Author

@Rigidity I tweaked the login screen and header component to add some top padding on desktop. see if it look right.

@Rigidity Rigidity merged commit e597216 into xch-dev:main Feb 2, 2025
6 of 8 checks passed
@dkackman dkackman deleted the navbar branch February 2, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar nav on small desktop screen sizes is too close to the bottom
2 participants