Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DB interface methods #647

Closed
wants to merge 2 commits into from
Closed

Update DB interface methods #647

wants to merge 2 commits into from

Conversation

andrew-farries
Copy link
Collaborator

Make two changes to the DB interface:

  • Update the WithRetryableTransaction signature to accept a *sql.TxOptions parameter. This allows for starting transactions at isolation levels other than the default READ COMMITTED.
  • Add a RawConn() method to retrieve an underlying *sql.DB .

Both of these changes are prerequisite steps for addressing #583

@andrew-farries
Add a RawConn method to the DB interface
e16e921 
`RawConn` returns the underlying `*sql.DB` for the connection.
@andrew-farries
Update WithRetryableTransaction method
12abfb0 
Change the method signature to accept `sql.TxOptions` as the second
argument. This allows transactions to run at isolation levels other than
the default `READ COMMITTED` level.
@andrew-farries
Copy link
Collaborator Author

Going to close this and include the changes as part of #648 as these changes are only needed if we merge #648.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrew-farries