CA-405417: add tracing of process holding device #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Syms <[email protected]>
edwintorok
reviewed
Jan 27, 2025
| @@ -446,15 +446,15 @@ def _openExclusive(dev, retry): | |||
| try: | |||
| return os.open("%s" % dev, os.O_RDWR | os.O_EXCL) | |||
| except OSError as ose: | |||
| opened_by = '' | |||
| ret = util.pread2(["lsof", dev]) | |||
There was a problem hiding this comment.
I think lsof can get stuck though if you have a stuck remote filesystem (NFS/GFS2), because as it looks through /proc it might try to resolve links pointing to these FS.
Or at least fuser would get stuck, and we had to remove a usage of that from XAPI to prevent XAPI from getting stuck:
xapi-project/xen-api#6197
Is it possible to run this command, but with a timeout so it doesn't completely block everything?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.