Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release pipeline #433

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Fix release pipeline #433

merged 2 commits into from
Dec 17, 2024

Conversation

fussel178
Copy link
Member

@fussel178 fussel178 commented Dec 17, 2024

Summary

This PR tries to fix the release pipelines for prereleases and releases.

It adds a proper git user to allow the backend-go job tagging and pushing of the required go tag.
(see https://github.com/wuespace/telestion/tree/main/backend-go#releasing-a-new-version)

Additionally, it sets the npm registry in the frontend-react job to hopefully convince npm to use the NODE_AUTH_TOKEN. 🙈

Details

n/a

Additional information

n/a

Related links

  • Fixes # .

CLA

  • I have signed the individual contributor's license agreement and sent it to the board of the WüSpace e. V. organization.

Hopefully this allows pnpm publish (aka npm publish) to properly use the npm token in AUTH_NODE_TOKEN without any additional setup.
see npm/cli#1637
see pnpm/pnpm#4937
@fussel178 fussel178 added 🐛 bug Something isn't working 🏃 github_actions GitHub Action changes that hit almost all workflows in the ecosystem labels Dec 17, 2024
@fussel178 fussel178 requested a review from pklaschka December 17, 2024 16:46
@fussel178 fussel178 self-assigned this Dec 17, 2024
Copy link
Member

@pklaschka pklaschka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (let's figure out on main if it works 🙈 )

@fussel178 fussel178 merged commit 2993291 into main Dec 17, 2024
13 checks passed
@fussel178 fussel178 deleted the fix/release-pipeline branch December 17, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🏃 github_actions GitHub Action changes that hit almost all workflows in the ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants