A lot of cleanup #64
Merged
A lot of cleanup #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kevmoo
commented
Jul 26, 2023
kevmoo
commented
- Made a number of APIs not-nullable
- Made a number of fields final where they could be
- Added types to a few public APIs
- Enabled and fixed a bunch of new lints
- Moved part files to the lib/src dir
- Require Dart 3
- Made a number of APIs not-nullable - Made a number of fields final where they could be - Added types to a few public APIs - Enabled and fixed a bunch of new lints - Moved part files to the lib/src dir - Require Dart 3
|
Ooo...looks like CI might be turned off for your repo 🤷 |
|
Hi Kev - this looks awesome. Not sure why the CI is not running... let me take a look |
|
I think GH disabled the workflow after 60 days. I'm going to merge this now (assuming you've run all tests/) - and I'll figure out how to enable CI later. Thanks so much for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.