Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Choreo] Go control plane version upgrade #3490

Merged
merged 3 commits into from
Feb 7, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove error status addition in rl filter
slahirucd7 committed Feb 7, 2024
commit ad1f2f71fef59bb44e9c8dd79b2fb636d9411128
4 changes: 0 additions & 4 deletions adapter/internal/oasparser/envoyconf/http_filters.go
Original file line number Diff line number Diff line change
@@ -34,7 +34,6 @@ import (
wasm_filter_v3 "github.com/envoyproxy/go-control-plane/envoy/extensions/filters/http/wasm/v3"
hcmv3 "github.com/envoyproxy/go-control-plane/envoy/extensions/filters/network/http_connection_manager/v3"
wasmv3 "github.com/envoyproxy/go-control-plane/envoy/extensions/wasm/v3"
typev3 "github.com/envoyproxy/go-control-plane/envoy/type/v3"
"github.com/envoyproxy/go-control-plane/pkg/wellknown"
"github.com/golang/protobuf/ptypes/wrappers"
"google.golang.org/protobuf/types/known/anypb"
@@ -168,9 +167,6 @@ func getRateLimitFilter() *hcmv3.HttpFilter {
},
},
},
StatusOnError: &typev3.HttpStatus{
Code: typev3.StatusCode_ServiceUnavailable,
},
}
ext, err2 := anypb.New(rateLimit)
if err2 != nil {