Upgrade base OS and jdk #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from this point onwards mgw will use base image's jdk instead mgw's internal jre. This makes it easier to upgrade mgw base image jdk without needing an immediate mgw patch release.
Rajith90
reviewed
Oct 24, 2020
Rajith90
reviewed
Oct 24, 2020
Rajith90
approved these changes
Oct 24, 2020
|
FYI, after an internal discussion we (rajith me and the team) decided to go with external jre so that we have the flexibility to easily upgrade docker image jre without going through an immediate mgw patch release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Issues
Fixes #4
Tested environments
Not Tested
Maintainers: Check before merge