Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API resources and access control for user share API. #6373

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.54%. Comparing base (3992a69) to head (0a31bd4).
Report is 136 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6373      +/-   ##
============================================
+ Coverage     46.36%   46.54%   +0.17%     
- Complexity    14770    14840      +70     
============================================
  Files          1714     1723       +9     
  Lines        103938   104066     +128     
  Branches      18630    18619      -11     
============================================
+ Hits          48195    48433     +238     
+ Misses        48852    48737     -115     
- Partials       6891     6896       +5     
Flag Coverage Δ
unit 30.27% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yasasr1 Yasasr1 force-pushed the user-share-api-reg branch from c50f509 to 1d152a9 Compare January 26, 2025 18:15
@@ -917,6 +917,30 @@
description="Introspect tokens"/>
</Scopes>
</APIResource>
<APIResource name="User Share API" identifier="/api/server/v1/users"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<APIResource name="User Share API" identifier="/api/server/v1/users"
<APIResource name="User Sharing API" identifier="/api/server/v1/users"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BimsaraBodaragama let's update the API definition from a separate PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update other places as well

@Yasasr1 Yasasr1 force-pushed the user-share-api-reg branch from 1d152a9 to 0a31bd4 Compare January 27, 2025 04:25
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12982049288

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12982049288
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12983440492

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12983440492
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12984912065

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12984912065
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12984912065

@AnuradhaSK AnuradhaSK merged commit 7f9f579 into wso2:master Jan 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants