Introduce DB based Admin Banner DAO implementation #6367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darshanasbg
reviewed
Jan 26, 2025
| org.wso2.carbon.identity.core.cache; version="${carbon.identity.package.import.version.range}", | ||
| org.wso2.carbon.admin.advisory.mgt.dao; version="${carbon.kernel.package.import.version.range}", | ||
| org.wso2.carbon.admin.advisory.mgt.dto; version="${carbon.kernel.package.import.version.range}", | ||
| org.wso2.carbon.admin.advisory.mgt.service; version="${carbon.kernel.package.import.version.range}", |
darshanasbg
reviewed
Jan 26, 2025
...c/main/java/org/wso2/carbon/identity/cors/mgt/core/advisorybanner/DBBasedAdminBannerDAO.java
Show resolved
Hide resolved
darshanasbg
reviewed
Jan 26, 2025
| </Import-Package> | ||
| <Export-Package> | ||
| !org.wso2.carbon.identity.cors.mgt.core.internal, | ||
| org.wso2.carbon.identity.cors.mgt.core.*; version="${project.version}", | ||
| </Export-Package> | ||
| <DynamicImport-Package>*</DynamicImport-Package> |
There was a problem hiding this comment.
Why do we need dynamic imports?
UdeshAthukorala
force-pushed
the
admin-banner
branch
from
601d90b to
f8886a4
Compare
darshanasbg
reviewed
Jan 26, 2025
| List<ResourceFile> resourceFiles = getConfigurationManager().getFiles(ADVISORY_BANNER_RESOURCE_TYPE, | ||
| ADVISORY_BANNER_RESOURCE_NAME); | ||
|
|
||
| if (resourceFiles.isEmpty() || StringUtils.isBlank(resourceFiles.get(0).getId())) { |
There was a problem hiding this comment.
shall we do a null check for resourceFiles.get(0)
UdeshAthukorala
force-pushed
the
admin-banner
branch
from
f8886a4 to
7cb02f7
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
$subject