Introduce JDBC based persistence for SAML #6287
Conversation
Osara-B
force-pushed
the
refactor-saml2
branch
2 times, most recently
from
93f9d76 to
f25b8dc
Compare
| "An error occurred while retrieving the " + "the service provider with the issuer '%s'", issuer), | ||
| e); | ||
| } | ||
| if (serviceProviderDO == null) { |
There was a problem hiding this comment.
lets convert this to,
if (serviceProviderDO != null) {
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6287 +/- ##
============================================
+ Coverage 45.89% 46.03% +0.13%
- Complexity 14420 14492 +72
============================================
Files 1654 1657 +3
Lines 103215 103587 +372
Branches 18203 18251 +48
============================================
+ Hits 47375 47688 +313
- Misses 49062 49085 +23
- Partials 6778 6814 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| try { | ||
| String tenantDomain = IdentityTenantUtil.getTenantDomain(tenantId); | ||
| // Load the certificate stored in the database, if signature validation is enabled. | ||
| if (serviceProviderDO.isDoValidateSignatureInRequests() || | ||
| serviceProviderDO.isDoValidateSignatureInArtifactResolve() || | ||
| serviceProviderDO.isDoEnableEncryptedAssertion()) { | ||
|
|
||
| Tenant tenant = IdentityTenantUtil.getTenant(tenantId); | ||
| serviceProviderDO.setX509Certificate(getApplicationCertificate(serviceProviderDO, tenant)); | ||
| } | ||
| serviceProviderDO.setTenantDomain(tenantDomain); |
There was a problem hiding this comment.
Can't we move this logic to the manager?
| public boolean isServiceProviderExists(String issuer, int tenantId) throws IdentityException { | ||
|
|
||
| try { | ||
| return processIsServiceProviderExists(issuer, tenantId); |
There was a problem hiding this comment.
Lets move processIsServiceProviderExists impl to here.
|
|
||
| List<SAMLSSOServiceProviderDO> serviceProvidersList; | ||
| try { | ||
| serviceProvidersList = processGetServiceProviders(tenantId); |
There was a problem hiding this comment.
Lets move processGetServiceProviders impl to here.
| public boolean removeServiceProvider(String issuer, int tenantId) throws IdentityException { | ||
|
|
||
| try { | ||
| processDeleteServiceProvider(issuer, tenantId); |
There was a problem hiding this comment.
Lets move processDeleteServiceProvider impl here
| SAMLSSOServiceProviderDO serviceProviderDO = null; | ||
|
|
||
| try { | ||
| serviceProviderDO = processGetServiceProvider(issuer, tenantId); |
There was a problem hiding this comment.
Lets move processGetServiceProvider impl here.
Osara-B
force-pushed
the
refactor-saml2
branch
from
f25b8dc to
480caf6
Compare
|
Introduce JDBC based persistence for SAML. Related to,