Add support to connect to the LoginFlow AI service #6260

sahandilshan · 2025-01-06T05:29:50Z

Proposed changes in this pull request

With this PR, the product-is will be able to connect the loginflow AI microservice and generate AI results accordingly

Related Issue(s)

AI-Powered Login Flow feature product-is#20040

# Conflicts: # components/application-mgt/org.wso2.carbon.identity.application.mgt/pom.xml # pom.xml

- Define constants for reusable keys - Remove token decoding and get the clientId from the AI KEY

# Conflicts: # components/ai-services-mgt/org.wso2.carbon.ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/constants/AIConstants.java # components/ai-services-mgt/org.wso2.carbon.ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java # components/ai-services-mgt/org.wso2.carbon.ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/util/AIHttpClientUtil.java # components/application-mgt/org.wso2.carbon.identity.application.mgt/pom.xml # pom.xml

...on.mgt/src/main/java/org/wso2/carbon/identity/application/mgt/ai/LoginFlowAIManagerImpl.java

janakamarasena · 2025-01-09T09:06:09Z

...arbon.ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/constants/AIConstants.java

+     */
+    public enum ErrorMessages {
+
+        MAXIMUM_RETRIES_EXCEEDED("AI_10000", "Maximum retries exceeded to retrieve the access token."),


Make the error code consistent with other components. IIRC we don't us "_" instead use "-"

...i.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/exceptions/AIServerException.java

janakamarasena · 2025-01-09T09:12:10Z

...i.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/exceptions/AIServerException.java

+public class AIServerException extends Exception {
+
+    private String errorCode;
+    private AIHttpClientUtil.HttpResponseWrapper loginFlowAIResponse;


Let's stop transmitting the error details as a object and include the details directly into the exception

...i.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/exceptions/AIClientException.java

janakamarasena · 2025-01-09T09:23:19Z

....ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java

+        return new AccessTokenRequestHelper(AI_KEY, AI_TOKEN_ENDPOINT,
+                // Here we keep the default HTTP client to send the token request.
+                // We open and close it for each request.
+                HttpAsyncClients.createDefault());


I don't see a reason to use the Async Client here. Lets check and switch to closable http client

....ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java

janakamarasena · 2025-01-09T09:35:09Z

...arbon.ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/util/AIHttpClientUtil.java

+            HTTP_CONNECTION_POOL_SIZE_PROPERTY_NAME) != null ? Integer.parseInt(IdentityUtil.getProperty(
+                    HTTP_CONNECTION_POOL_SIZE_PROPERTY_NAME)) : 20;
+    private static final int HTTP_CONNECTION_TIMEOUT = IdentityUtil.getProperty(
+            HTTP_CONNECTION_TIMEOUT_PROPERTY_NAME) != null ? Integer.parseInt(IdentityUtil.getProperty(
+            HTTP_CONNECTION_TIMEOUT_PROPERTY_NAME)) : 60000; // Making the default timeout 60 seconds.


move the defaults to a constant.

janakamarasena · 2025-01-09T09:38:30Z

...arbon.ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/util/AIHttpClientUtil.java

+
+        try {
+            String accessToken = AIAccessTokenManager.getInstance().getAccessToken(false);
+            String orgName = AIAccessTokenManager.getInstance().getClientId();


lets rename to clientId

janakamarasena · 2025-01-09T09:47:06Z

...on.mgt/src/main/java/org/wso2/carbon/identity/application/mgt/ai/LoginFlowAIManagerImpl.java

+        Map<String, Object> requestBody = new HashMap<>();
+        requestBody.put(USER_QUERY_PROPERTY, userQuery);
+        try {
+            // Convert JSONArray to List.


Lets remove unnecessary comments.

janakamarasena · 2025-01-09T09:49:16Z

...on.mgt/src/main/java/org/wso2/carbon/identity/application/mgt/ai/LoginFlowAIManagerImpl.java

+     * @throws AIClientException When an error occurs while generating the authentication sequence.
+     */
+    @Override
+    public String generateAuthenticationSequence(String userQuery, JSONArray userClaims,


lets rename userClaims to mean the what we are actually getting (the claim metadata)

janakamarasena · 2025-01-09T10:18:49Z

...src/main/java/org/wso2/carbon/identity/application/mgt/ai/constant/LoginFlowAIConstants.java

+        MAXIMUM_RETRIES_EXCEEDED("AILF_10000", "Maximum retries exceeded to retrieve the access token."),
+        UNABLE_TO_ACCESS_AI_SERVICE_WITH_RENEW_ACCESS_TOKEN("AILF_10003", "Unable to access the " +
+                "AI service with the renewed access token."),


Are these being used?

janakamarasena · 2025-01-09T10:39:07Z

...on.mgt/src/test/java/org/wso2/carbon/identity/application/mgt/ai/LoginFlowAIManagerTest.java

+import static org.wso2.carbon.base.MultitenantConstants.SUPER_TENANT_DOMAIN_NAME;
+import static org.wso2.carbon.base.MultitenantConstants.SUPER_TENANT_ID;
+
+public class LoginFlowAIManagerTest {


Missing class comment

- Make the component as identity component (Rename from carbon to carbon.identity) - Remove usage Async http client - Clean the code

janakamarasena · 2025-01-16T09:56:39Z

...cation.mgt/src/main/java/org/wso2/carbon/identity/application/mgt/ai/LoginFlowAIManager.java

+ */
+public interface LoginFlowAIManager {
+
+    String generateAuthenticationSequence(String userQuery, JSONArray userClaims, JSONObject availableAuthenticators)


Add method comments

jenkins-is-staging · 2025-01-16T13:51:08Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12810307037

jenkins-is-staging · 2025-01-16T13:52:58Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12810307037
Status: failure

jenkins-is-staging · 2025-01-16T15:40:22Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12812386496

sonarqubecloud · 2025-01-16T15:41:48Z

Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.0% Duplication on New Code

See analysis details on SonarQube Cloud

jenkins-is-staging · 2025-01-16T15:55:58Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12812386496
Status: failure

sahandilshan added 25 commits October 3, 2024 17:08

Add support to connect to the LoginFlow AI service

e73a82c

Add AI Management component

2c24dee

Add ai feature component

22bcf9b

Add loginflow AI capability

3532bd4

Merge remote-tracking branch 'upstream/master' into loginflow-ai-2

c3431ee

Bump new component version

2df174b

Fix code quality

5367ae1

Bump AI version to latest framework version

ddfaf3c

Add more unit tests to cover complex scenarios

ed01d0b

Merge remote-tracking branch 'upstream/master' into loginflow-ai-2

a6f353b

# Conflicts: # components/application-mgt/org.wso2.carbon.identity.application.mgt/pom.xml # pom.xml

Bump framework version in AI components

bbf57d7

Fix checkstyle issues

d928d9a

Add support to connect to the LoginFlow AI service

45ab16e

Add AI Management component

d9e0ba2

Add ai feature component

90ae363

Add loginflow AI capability

b4df626

Bump new component version

57f6c5f

Fix code quality

ddc1733

Bump AI version to latest framework version

16e792e

Add more unit tests to cover complex scenarios

a5229cc

Bump framework version in AI components

da6360b

Fix checkstyle issues

95eef11

Add support for connection pool with other improvements

aca5555

- Define constants for reusable keys - Remove token decoding and get the clientId from the AI KEY

Modify LoginFlowAI Implementation

cdad525

sahandilshan commented Jan 6, 2025

View reviewed changes

...on.mgt/src/main/java/org/wso2/carbon/identity/application/mgt/ai/LoginFlowAIManagerImpl.java Outdated Show resolved Hide resolved

sahandilshan commented Jan 6, 2025

View reviewed changes

...on.mgt/src/main/java/org/wso2/carbon/identity/application/mgt/ai/LoginFlowAIManagerImpl.java Outdated Show resolved Hide resolved

sahandilshan force-pushed the loginflow-ai-2 branch 3 times, most recently from 92b41bd to 73a9b36 Compare January 8, 2025 08:39

janakamarasena reviewed Jan 9, 2025

View reviewed changes

...i.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/exceptions/AIServerException.java Outdated Show resolved Hide resolved

janakamarasena reviewed Jan 9, 2025

View reviewed changes

...i.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/exceptions/AIClientException.java Outdated Show resolved Hide resolved

janakamarasena reviewed Jan 9, 2025

View reviewed changes

....ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java Outdated Show resolved Hide resolved

janakamarasena reviewed Jan 9, 2025

View reviewed changes

sahandilshan added 3 commits January 10, 2025 16:12

Refactor AI service

3f1f8db

- Make the component as identity component (Rename from carbon to carbon.identity) - Remove usage Async http client - Clean the code

Merge remote-tracking branch 'upstream/master' into loginflow-ai-2

fbb6f4b

Update the new component version

f177247

sahandilshan force-pushed the loginflow-ai-2 branch from aa4eea3 to f177247 Compare January 10, 2025 15:20

janakamarasena reviewed Jan 16, 2025

View reviewed changes

sahandilshan force-pushed the loginflow-ai-2 branch 4 times, most recently from c31c746 to e61ae0d Compare January 16, 2025 12:57

janakamarasena previously approved these changes Jan 16, 2025

View reviewed changes

Fix review suggestions

458e913

sahandilshan dismissed janakamarasena’s stale review via 458e913 January 16, 2025 15:39

sahandilshan force-pushed the loginflow-ai-2 branch from e61ae0d to 458e913 Compare January 16, 2025 15:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support to connect to the LoginFlow AI service #6260

Add support to connect to the LoginFlow AI service #6260

sahandilshan commented Jan 6, 2025

janakamarasena Jan 9, 2025

janakamarasena Jan 9, 2025

janakamarasena Jan 9, 2025

janakamarasena Jan 9, 2025

janakamarasena Jan 9, 2025

janakamarasena Jan 9, 2025

janakamarasena Jan 9, 2025

janakamarasena Jan 9, 2025

janakamarasena Jan 9, 2025

janakamarasena Jan 16, 2025

jenkins-is-staging commented Jan 16, 2025

jenkins-is-staging commented Jan 16, 2025

jenkins-is-staging commented Jan 16, 2025

sonarqubecloud bot commented Jan 16, 2025

jenkins-is-staging commented Jan 16, 2025

Add support to connect to the LoginFlow AI service #6260

Are you sure you want to change the base?

Add support to connect to the LoginFlow AI service #6260

Conversation

sahandilshan commented Jan 6, 2025

Proposed changes in this pull request

Related Issue(s)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jenkins-is-staging commented Jan 16, 2025

jenkins-is-staging commented Jan 16, 2025

jenkins-is-staging commented Jan 16, 2025

sonarqubecloud bot commented Jan 16, 2025

Quality Gate passed

jenkins-is-staging commented Jan 16, 2025