-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete API Key support implementation #2402
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7aca1bb
to
73c88a8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2402 +/- ##
==========================================
- Coverage 26.08% 19.91% -6.18%
==========================================
Files 68 229 +161
Lines 4769 26206 +21437
Branches 2451 2723 +272
==========================================
+ Hits 1244 5218 +3974
- Misses 3525 20800 +17275
- Partials 0 188 +188
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
63812bf
to
3603592
Compare
3603592
to
7d9c7bb
Compare
7d9c7bb
to
781a5d5
Compare
781a5d5
to
85301e2
Compare
85301e2
to
3f4f9ad
Compare
3f4f9ad
to
451ef7f
Compare
451ef7f
to
ee40967
Compare
ee40967
to
cbfd4ec
Compare
CrowleyRajapakse
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds the required field for API Key and supports the optionality of the authenticators similar to the APIM implementation.
Testing was done in CP to DP mode with an API Key generated from the APIM side.
Fixes #2399