Improve owner reference updates #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tharsanan1
force-pushed
the
improve-owner-reference-updates
branch
from
059c3bb to
6b4c486
Compare
Tharsanan1
added
trigger-action
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1948 +/- ##
==========================================
- Coverage 26.53% 26.31% -0.23%
==========================================
Files 124 124
Lines 14516 14640 +124
Branches 2575 2575
==========================================
Hits 3852 3852
- Misses 10540 10664 +124
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions
bot
removed
the
trigger-action
Tharsanan1
added
the
trigger-action
github-actions
bot
removed
the
trigger-action
Krishanx92
added
the
trigger-action
Tharsanan1
added
trigger-action
Tharsanan1
added
trigger-action
Tharsanan1
force-pushed
the
improve-owner-reference-updates
branch
from
ace4d61 to
1013f2a
Compare
github-actions
bot
removed
the
trigger-action
Tharsanan1
added
the
trigger-action
| apiReconciler.handleOwnerReference(ctx, &cm, &requests) | ||
| case *gwapiv1b1.HTTPRoute: | ||
| var httpRoute gwapiv1b1.HTTPRoute | ||
| namesapcedName := types.NamespacedName{ |
There was a problem hiding this comment.
i think we have a util for getting the namespaced name for k8 object
AmaliMatharaarachchi
approved these changes
Jan 17, 2024
github-actions
bot
removed
the
trigger-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose