Change authenticator property keys to be specific for different authenticators #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZiyamSanthosh
commented
Jul 3, 2024
| String nonce = UUID.randomUUID().toString(); | ||
| context.setProperty(OIDC_FEDERATION_NONCE, nonce); | ||
| context.setProperty(getName() + OIDC_FEDERATION_NONCE, nonce); |
There was a problem hiding this comment.
@janakamarasena Is it okay to change the nonce value name by adding the authenticator name as the prefix?
There was a problem hiding this comment.
+1. Even though this is used in the normal flow and not only dedicated for app native auth it should be okay as this should not be used outside of the authenicator
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/9783516912
ZiyamSanthosh
changed the title
pamodaaw
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding the properties such as redirect_url, scope, state and nonce into the authentication context, use the specific authenticator name as the prefix to uniquely identify the specific keys according to each authenticator.
Related issue: