-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip email domain validation for shared user creation #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
=============================================
- Coverage 41.53% 26.03% -15.51%
- Complexity 218 346 +128
=============================================
Files 30 50 +20
Lines 1678 4145 +2467
Branches 187 478 +291
=============================================
+ Hits 697 1079 +382
- Misses 938 2984 +2046
- Partials 43 82 +39 ☔ View full report in Codecov by Sentry. |
AnuradhaSK
reviewed
Oct 24, 2024
...tity/organization/discovery/service/listener/OrganizationDiscoveryUserOperationListener.java
Outdated
Show resolved
Hide resolved
....organization.discovery.service/listener/OrganizationDiscoveryUserOperationListenerTest.java
Outdated
Show resolved
Hide resolved
HasiniSama
force-pushed
the
1.4.50
branch
4 times, most recently
from
October 24, 2024 07:05
4f3b2f0
to
b81b53c
Compare
...tity/organization/discovery/service/listener/OrganizationDiscoveryUserOperationListener.java
Outdated
Show resolved
Hide resolved
AnuradhaSK
reviewed
Oct 24, 2024
....organization.discovery.service/listener/OrganizationDiscoveryUserOperationListenerTest.java
Show resolved
Hide resolved
AnuradhaSK
reviewed
Oct 24, 2024
....organization.discovery.service/listener/OrganizationDiscoveryUserOperationListenerTest.java
Outdated
Show resolved
Hide resolved
AnuradhaSK
reviewed
Oct 24, 2024
....organization.discovery.service/listener/OrganizationDiscoveryUserOperationListenerTest.java
Outdated
Show resolved
Hide resolved
sadilchamishka
approved these changes
Oct 24, 2024
SujanSanjula96
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes: wso2/product-is#21466
Goals
When creating a sub-organization, the root organization's user is shared within the sub-organization. However, if the domain of the root user is already associated with another sub-organization, user creation fails due to a domain validation error. This validation is not necessary for shared users.
Approach
Remove the domain validation for users when the user is created as either the root tenant admin or an invited user from the parent organization. This can be achieved by checking the managed-by claim of the user.