Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip email domain validation for shared user creation #405

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

HasiniSama
Copy link
Contributor

Purpose

Fixes: wso2/product-is#21466

Goals

When creating a sub-organization, the root organization's user is shared within the sub-organization. However, if the domain of the root user is already associated with another sub-organization, user creation fails due to a domain validation error. This validation is not necessary for shared users.

Approach

Remove the domain validation for users when the user is created as either the root tenant admin or an invited user from the parent organization. This can be achieved by checking the managed-by claim of the user.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.03%. Comparing base (f389c4b) to head (706acfb).
Report is 13 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main     #405       +/-   ##
=============================================
- Coverage     41.53%   26.03%   -15.51%     
- Complexity      218      346      +128     
=============================================
  Files            30       50       +20     
  Lines          1678     4145     +2467     
  Branches        187      478      +291     
=============================================
+ Hits            697     1079      +382     
- Misses          938     2984     +2046     
- Partials         43       82       +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HasiniSama HasiniSama force-pushed the 1.4.50 branch 4 times, most recently from 4f3b2f0 to b81b53c Compare October 24, 2024 07:05
@SujanSanjula96 SujanSanjula96 merged commit 775fa9d into wso2-extensions:main Oct 24, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organization creation fails when using email domain-based organization discovery
4 participants