Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support to invite multiple users to the sub org from parent org #315

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Support to invite multiple users to the sub org from parent org #315

merged 5 commits into from
Dec 13, 2023

Conversation

Kanapriya
Copy link
Contributor

@Kanapriya Kanapriya commented Nov 30, 2023 •
edited
Loading

Purpose

Fix wso2/product-is#16719

Goals

This fix will enable to invite multiple users to the sub organization from the parent organization at once with the set of roles.

Approach

  • Used the same api/server/v1/guests/invite endpoint to create multiple users at once with the same set of roles
  • Rather failing the whole flow upon any failure due to any of the invalid user, continue the invitation creation as we need to find the actual failures and skipped users list in order to re-initiate user invitation.
  • If the invitations creation successful to all of the given users, then the output will contains the successful response with the created invitation details, otherwise the final response will contain the skipped user's list.

@Kanapriya Kanapriya mentioned this pull request Nov 30, 2023
Merged
@Kanapriya
Support to invite multiple users to the sub org from parent org
2d1aa55 
Changed the variable name

Add minor changes
@Kanapriya Kanapriya force-pushed the multi_user_cretion branch 2 times, most recently from 4ed02e0 to b85d247 Compare December 4, 2023 20:16
@Kanapriya
Address review comments
d70069b 
Address review comments

Add minor improvement

Address review comments

Address minor improvement

Improve the model
@Kanapriya Kanapriya force-pushed the multi_user_cretion branch 2 times, most recently from 74510c3 to d2627de Compare December 11, 2023 10:23
@Kanapriya
Address review comments
821d1c6 
format the code

Formatting

Address review changes
@Kanapriya Kanapriya merged commit 60d43f4 into wso2-extensions:main Dec 13, 2023
1 check passed
hwupathum pushed a commit to hwupathum/identity-organization-management that referenced this pull request Jan 23, 2024
@wso2-jenkins-bot
[WSO2 Release] [Jenkins wso2-extensions#315] [Release 1.3.49] prepare…
c68bdaf 
… release v1.3.49
hwupathum pushed a commit to hwupathum/identity-organization-management that referenced this pull request Jan 23, 2024
@wso2-jenkins-bot
[WSO2 Release] [Jenkins wso2-extensions#315] [Release 1.3.49] prepare…
a5f83f8 
… for next development iteration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadilchamishka sadilchamishka sadilchamishka left review comments

@ShanChathusanda93 ShanChathusanda93 ShanChathusanda93 left review comments

@dewniMW dewniMW dewniMW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Kanapriya @ShanChathusanda93 @dewniMW @sadilchamishka