Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use organization owner information when sharing the organization creator and block sharing the owner when not reside in parent for self-service org onboard #314

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Use organization owner information when sharing the organization creator and block sharing the owner when not reside in parent for self-service org onboard #314

merged 7 commits into from
Dec 18, 2023

Conversation

sadilchamishka
Copy link
Contributor

@sadilchamishka sadilchamishka commented Nov 30, 2023 •
edited
Loading

Purpose

  1. Previously, the shared user information was retrieved from the carbon context. But retrieving the shared user information from the organization owner details which stored in the corresponding tenant's realm config will be more reliable.
    Ex - There can be use cases where the organization onboarding by self service portal and the request initiator is not the owner of the created organization.
  1. The console admin role should be assigned for the organization creator only if the authenticated application is console.

Depends on

Related Issues

Untitled-2022-10-29-2045

@sadilchamishka sadilchamishka force-pushed the get-tenant-admin-info-when-sharing-creator branch 4 times, most recently from e8d0c23 to 621520b Compare December 11, 2023 08:43
@sadilchamishka sadilchamishka force-pushed the get-tenant-admin-info-when-sharing-creator branch from 621520b to 5e487c2 Compare December 14, 2023 10:08
@sadilchamishka sadilchamishka changed the title Use organization owner information when sharing the organization creator Use organization owner information when sharing the organization creator and block sharing the owner when not reside in parent for self-service org onboard Dec 14, 2023
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7207763788

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7207763788
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7210847613

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7210847613
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Dec 14, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7210847613

@sadilchamishka
Remove the condition of blocking the organization owner sharing when …
224d620 
…self service org onboard with admin resides in the organization
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7244627727

@sadilchamishka sadilchamishka force-pushed the get-tenant-admin-info-when-sharing-creator branch from d39e766 to f5fdd35 Compare December 18, 2023 07:39
@sadilchamishka sadilchamishka merged commit 433d1b0 into wso2-extensions:main Dec 18, 2023
2 checks passed
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7244627727
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Dec 18, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7244627727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@dewniMW dewniMW dewniMW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sadilchamishka @jenkins-is-staging @dewniMW