Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage application name update of fragment apps. #269

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Manage application name update of fragment apps. #269

merged 1 commit into from
Oct 25, 2023

Conversation

ChanikaRuchini
Copy link
Contributor

Purpose

with this PR

  • When the app name of shared app gets updated, app name of fragment apps also will update
  • Blocked the app name update of fragments app through APIS.

Fixes for

thanujalk
thanujalk previously approved these changes Oct 24, 2023
View reviewed changes
sadilchamishka
sadilchamishka reviewed Oct 24, 2023
View reviewed changes
...on/identity/organization/management/application/listener/FragmentApplicationMgtListener.java
IdentityUtil.threadLocalProperties.get()
.put(UPDATED_APPLICATION_NAME, serviceProvider.getApplicationName());
}
} else if (!isInternalProcess(tenantDomain)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic need not be inside else if block. You can have as a normal if condition by checking the application update by internal process of root org. If name is different, can throw the exception.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only sub organizations name update using external process should be blocked. therfore added the else if block

@ChanikaRuchini ChanikaRuchini force-pushed the subord-app-name-update branch 2 times, most recently from d313ae0 to 68d8c89 Compare October 25, 2023 05:12
@ChanikaRuchini ChanikaRuchini mentioned this pull request Oct 25, 2023
Merged
9 tasks
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6638300315

@ChanikaRuchini ChanikaRuchini merged commit 60e8268 into wso2-extensions:main Oct 25, 2023
1 check passed
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6638300315
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Oct 25, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6638300315

JeethJJ pushed a commit to JeethJJ/identity-organization-management that referenced this pull request Nov 7, 2023
@wso2-jenkins-bot
[WSO2 Release] [Jenkins wso2-extensions#269] [Release 1.3.27] prepare…
c73d90f 
… release v1.3.27
JeethJJ pushed a commit to JeethJJ/identity-organization-management that referenced this pull request Nov 7, 2023
@wso2-jenkins-bot
[WSO2 Release] [Jenkins wso2-extensions#269] [Release 1.3.27] prepare…
01be1e7 
… for next development iteration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadilchamishka sadilchamishka sadilchamishka left review comments

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@AnuradhaSK AnuradhaSK AnuradhaSK approved these changes

@thanujalk thanujalk thanujalk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChanikaRuchini @jenkins-is-staging @thanujalk @AnuradhaSK @sadilchamishka