Address review comments

wso2-extensions · Oct 24, 2023 · 3da2b8e · 3da2b8e
1 parent f4f7b27
commit 3da2b8e
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 4 deletions.
diff --git a/...onents/org.wso2.carbon.identity.organization.management.organization.user.sharing/pom.xml b/...onents/org.wso2.carbon.identity.organization.management.organization.user.sharing/pom.xml
@@ -20,7 +20,7 @@
     <parent>
         <groupId>org.wso2.carbon.identity.organization.management</groupId>
         <artifactId>identity-organization-management</artifactId>
-        <version>1.3.91-SNAPSHOT</version>
+        <version>1.3.92-SNAPSHOT</version>
         <relativePath>../../pom.xml</relativePath>
     </parent>
 

diff --git a/...ity/organization/management/organization/user/sharing/OrganizationUserSharingService.java b/...ity/organization/management/organization/user/sharing/OrganizationUserSharingService.java
@@ -45,7 +45,7 @@ void shareOrganizationUser(String orgId, String associatedUserId, String associa
      * @return True if the user associations are deleted successfully.
      * @throws OrganizationManagementException If an error occurs while deleting the user associations.
      */
-    boolean unShareOrganizationUsers(String associatedUserId, String associatedOrgId)
+    boolean unshareOrganizationUsers(String associatedUserId, String associatedOrgId)
             throws OrganizationManagementException;
 
     /**

diff --git a/...organization/management/organization/user/sharing/OrganizationUserSharingServiceImpl.java b/...organization/management/organization/user/sharing/OrganizationUserSharingServiceImpl.java
@@ -76,7 +76,7 @@ public void shareOrganizationUser(String orgId, String associatedUserId, String
     }
 
     @Override
-    public boolean unShareOrganizationUsers(String associatedUserId, String associatedOrgId)
+    public boolean unshareOrganizationUsers(String associatedUserId, String associatedOrgId)
             throws OrganizationManagementException {
 
         List<UserAssociation> userAssociationList =

diff --git a/...tion/management/organization/user/sharing/internal/OrganizationUserSharingDataHolder.java b/...tion/management/organization/user/sharing/internal/OrganizationUserSharingDataHolder.java
@@ -37,21 +37,41 @@ public static OrganizationUserSharingDataHolder getInstance() {
         return instance;
     }
 
+    /**
+     * Get the organization manager service.
+     *
+     * @return Organization manager service.
+     */
     public OrganizationManager getOrganizationManager() {
 
         return organizationManager;
     }
 
+    /**
+     * Set the organization manager service.
+     *
+     * @param organizationManager Organization manager service.
+     */
     public void setOrganizationManager(OrganizationManager organizationManager) {
 
         this.organizationManager = organizationManager;
     }
 
+    /**
+     * Get the realm service.
+     *
+     * @return Realm service.
+     */
     public RealmService getRealmService() {
 
         return realmService;
     }
 
+    /**
+     * Set the realm service.
+     *
+     * @param realmService RealmService service.
+     */
     public void setRealmService(RealmService realmService) {
 
         this.realmService = realmService;

diff --git a/...ation/management/organization/user/sharing/listener/SharedUserOperationEventListener.java b/...ation/management/organization/user/sharing/listener/SharedUserOperationEventListener.java
@@ -71,7 +71,7 @@ public boolean doPreDeleteUserWithID(String userID, UserStoreManager userStoreMa
                         .resolveOrganizationId(getTenantDomain());
             }
             // Delete all the user associations of the user.
-            return organizationUserSharingService.unShareOrganizationUsers(userID, orgId);
+            return organizationUserSharingService.unshareOrganizationUsers(userID, orgId);
         } catch (OrganizationManagementException e) {
             throw new UserStoreException(e.getMessage(), e.getErrorCode(), e);
         }