Fix lack of exception when attempting to update a non-existent role name #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR builder started |
...2.common/src/test/java/org/wso2/carbon/identity/scim2/common/group/SCIMGroupHandlerTest.java
Outdated
Show resolved
Hide resolved
|
PR builder completed |
jenkins-is-staging
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/8182128692
ashensw
previously approved these changes
Mar 7, 2024
Sachin-Mamoru
previously approved these changes
Mar 7, 2024
pamodaaw
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Previously, when addressing wso2/product-is#14095, the updateRoleName method's was changed to print a warn log instead of throwing an exception via #435, which was a temporary fix which had not been reverted even after a proper fix was added.
This PR reverts the temporary fix and allows an exception to be thrown instead of a warn log.
With this change, the SOAP API will be able to identify the failure of the operation and return the status as 500 Internal Server Error along with the error message.
Related PRs
Related Issues