Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle UserStoreClient Exceptions thrown from the Pre Update Password Action Execution #911

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

ashanthamara
Copy link
Contributor

@ashanthamara ashanthamara commented Jan 26, 2025

Proposed changes in this pull request

  1. Previously UserstoreClientExceptions are considered as server errors and handled accordingly.
  2. But with the Pre Update password extension, we need to throw a client error from the recovery apis.
  3. Since UserstoreClientExceptions were treated as server errors before, we added an extra validation by checking the error code thrown from the pre update password action component just to be precise on the error scenario.
  4. Hence adding the pre update password action dependency to the repository.

Related Issue:

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12979055035

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 50.91%. Comparing base (15aca18) to head (8d04530).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../password/NotificationPasswordRecoveryManager.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #911      +/-   ##
============================================
- Coverage     50.92%   50.91%   -0.01%     
+ Complexity     2454     2448       -6     
============================================
  Files           300      300              
  Lines         18081    18086       +5     
  Branches       2609     2611       +2     
============================================
+ Hits           9207     9208       +1     
- Misses         7715     7719       +4     
  Partials       1159     1159              
Flag Coverage Δ
unit 38.67% <20.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12979055035
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12979108416

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12979108416
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12979108416

@ashanthamara ashanthamara merged commit 238bafe into wso2-extensions:master Jan 27, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants