Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disregard callback url regex validation when accessurl is configured in the app #787

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Disregard callback url regex validation when accessurl is configured in the app #787

merged 3 commits into from
Dec 6, 2023

Conversation

ashanthamara
Copy link
Contributor

@ashanthamara ashanthamara commented Dec 3, 2023 •
edited
Loading

This was referenced Dec 3, 2023
Merged
Merged
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7085842249

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7085842249
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7098698590

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7098698590
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Dec 5, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7098698590

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7103103351

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7103103351
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Dec 5, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7103103351

@chamathns chamathns merged commit 510730c into wso2-extensions:master Dec 6, 2023
2 checks passed
@ashanthamara ashanthamara mentioned this pull request Mar 25, 2024
Merged
Yoshani
Yoshani reviewed Mar 26, 2024
View reviewed changes
...so2.carbon.identity.recovery/src/main/java/org/wso2/carbon/identity/recovery/util/Utils.java
*/
public static Boolean isAccessUrlAvailable(org.wso2.carbon.identity.recovery.model.Property[] properties) {

if (properties != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we have an early return for null check?

if (properties == null) {
        return false;
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inthirakumaaran inthirakumaaran inthirakumaaran left review comments

@Yoshani Yoshani Yoshani left review comments

@chamathns chamathns chamathns approved these changes

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ashanthamara @jenkins-is-staging @inthirakumaaran @chamathns @Yoshani