Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve client error handling for notification template API #304

Merged

Conversation

madurangasiriwardena
Copy link
Member

@madurangasiriwardena madurangasiriwardena commented Feb 7, 2025

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 34.85%. Comparing base (79422ff) to head (9ee7a23).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...bon/email/mgt/NotificationTemplateManagerImpl.java 0.00% 12 Missing ⚠️
...so2/carbon/email/mgt/EmailTemplateManagerImpl.java 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #304      +/-   ##
============================================
+ Coverage     34.82%   34.85%   +0.03%     
  Complexity      515      515              
============================================
  Files            74       74              
  Lines          4945     4940       -5     
  Branches        640      638       -2     
============================================
  Hits           1722     1722              
+ Misses         3058     3053       -5     
  Partials        165      165              
Flag Coverage Δ
unit 20.48% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@madurangasiriwardena madurangasiriwardena merged commit 9ff52ef into wso2-extensions:master Feb 7, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception thrown while loading default SMS Templates in branding section
2 participants