Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to honour the locale for email notifications. #249

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Thisara-Welmilla
Copy link
Contributor

Issue:

Improvement to resolve locale attribute value of the authenticated user:
If a local user exists for the authenticated user, retrieve the locale value from the userStore. If no local user exists (either because it is the first time federated authentication or JIT provisioning is disabled), check the event properties for a local value, which will be set by the email authenticator step if there is a locale claim as an IDP claim. If neither of these conditions are met, set the default locale value.

@CLAassistant
Copy link

CLAassistant commented Jul 10, 2024

CLA assistant check
All committers have signed the CLA.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/9868033876

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/9868033876
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/9868033876

@Thisara-Welmilla Thisara-Welmilla force-pushed the Honour-locale-for-notifications branch from 9c3a092 to 3f6bff6 Compare July 10, 2024 09:02
@Thisara-Welmilla Thisara-Welmilla force-pushed the Honour-locale-for-notifications branch from 3f6bff6 to 92049ee Compare July 10, 2024 09:23
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 34.64%. Comparing base (79422ff) to head (2b85a5c).

Files with missing lines Patch % Lines
...nt/handler/notification/util/NotificationUtil.java 0.00% 23 Missing ⚠️
...ndler/notification/DefaultNotificationHandler.java 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #249      +/-   ##
============================================
- Coverage     34.82%   34.64%   -0.19%     
  Complexity      515      515              
============================================
  Files            74       74              
  Lines          4945     4942       -3     
  Branches        640      637       -3     
============================================
- Hits           1722     1712      -10     
- Misses         3058     3072      +14     
+ Partials        165      158       -7     
Flag Coverage Δ
unit 20.47% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants