Add support function to filter authenticators #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashendes
reviewed
Nov 22, 2023
components/org.wso2.carbon.identity.conditional.auth.functions.utils/pom.xml
Outdated
Show resolved
Hide resolved
| } else { | ||
| idpMap.put(FrameworkConstants.JSAttributes.IDP, idp); | ||
| } | ||
| result.put(String.valueOf(index++), idpMap); |
There was a problem hiding this comment.
Why can't we pass the integer value as it is here? Why do we need to make this value string?
There was a problem hiding this comment.
As in https://github.com/wso2/carbon-identity-framework/blob/1ceee196051722474017ab432cee84d4a949b7a3/components/authentication-framework/org.wso2.carbon.identity.application.authentication.framework/src/main/java/org/wso2/carbon/identity/application/authentication/framework/config/model/graph/JsNashornGraphBuilder.java#L371C27-L371C61, the expected return format is Map<String, Map<String, String>>
ashensw
reviewed
Nov 23, 2023
.../wso2/carbon/identity/conditional/auth/functions/utils/FilterAuthenticatorsFunctionImpl.java
Outdated
Show resolved
Hide resolved
ashensw
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix related to https://github.com/wso2-enterprise/asgardeo-product/issues/20580
Related PRs :