Modify getMaskedValue method to always mask the given value.

wso2-extensions · Jun 12, 2024 · a723747 · a723747
1 parent 6e7ae15
commit a723747
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/...ava/org/wso2/carbon/identity/conditional/auth/functions/utils/GetMaskedValueFunction.java b/...ava/org/wso2/carbon/identity/conditional/auth/functions/utils/GetMaskedValueFunction.java
@@ -19,13 +19,13 @@
 package org.wso2.carbon.identity.conditional.auth.functions.utils;
 
 /**
- * Function to mask the given value  if log masking is enabled.
+ * Function to mask the given value.
  */
 @FunctionalInterface
 public interface GetMaskedValueFunction {
 
     /**
-     * Masks the given value if log masking is enabled.
+     * Masks the given value.
      *
      * @param value The value to be masked.
      * @return The masked value.

diff --git a/...org/wso2/carbon/identity/conditional/auth/functions/utils/GetMaskedValueFunctionImpl.java b/...org/wso2/carbon/identity/conditional/auth/functions/utils/GetMaskedValueFunctionImpl.java
@@ -30,6 +30,6 @@ public class GetMaskedValueFunctionImpl implements GetMaskedValueFunction {
     @HostAccess.Export
     public String getMaskedValue(String value) {
 
-        return LoggerUtils.isLogMaskingEnable ? LoggerUtils.getMaskedContent(value) : value;
+        return  LoggerUtils.getMaskedContent(value);
     }
 }
diff --git a/...wso2/carbon/identity/conditional/auth/functions/utils/GetMaskedValueFunctionImplTest.java b/...wso2/carbon/identity/conditional/auth/functions/utils/GetMaskedValueFunctionImplTest.java
@@ -82,9 +82,13 @@ public void testGetMaskedValue(boolean isLogMaskingEnabled, String username, Str
     @DataProvider(name = "maskableValueProvider")
     public Object[][] maskableValueProvider() {
 
+        /*
+        The "getMaskedValue" method should always mask the passed in value
+         irrespective of the server-wide 'isLogMaskingEnable' configuration.
+         */
         return new Object[][]{
                 {true, "johndoe", "j*****e"},
-                {false, "johndoe", "johndoe"},
+                {false, "johndoe", "j*****e"},
         };
     }
 }