fix(ui): avoid bundling injectionKeys in custom components
#718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madeindjs
force-pushed
the
fix-custom-element
branch
from
c128d62 to
91826ac
Compare
The custom component built using `npm run custom.build` was not working correctly because the `provide/inject` failed. The error was, we bundled `injectionKeys` in the `template.umd.js` , So it makes defining two different `Symbol` which point to a different `provide`. It's because the `rollupOptions.external` in Vite config pointed to `../injectionKeys`, but we sometime use the alias `@/injectionKeys`. So I simply use `path.resolve` to be sure `injectionKeys` are not bundled in custom components.
madeindjs
force-pushed
the
fix-custom-element
branch
from
91826ac to
3d53c9c
Compare
src/ui/vite.config.custom.ts
Outdated
| @@ -29,11 +31,11 @@ export default defineConfig({ | |||
| }, | |||
| }, | |||
| rollupOptions: { | |||
| external: ["vue", "../injectionKeys"], | |||
| external: ["vue", injectionKeys], | |||
There was a problem hiding this comment.
I have to use this code to make the build of custom component working on windows.
rollupOptions: {
external: ["vue", "@/injectionKeys"],
output: {
globals: {
vue: "vue",
[path.resolve("src/injectionKeys")]: "injectionKeys",
},
},
},
```There was a problem hiding this comment.
I implemented it in d6fb5ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom component built using
npm run custom.buildwas not working correctly because theprovide/injectfailed.The error was, we bundled
injectionKeysin thetemplate.umd.js, So it makes defining two differentSymbolwhich point to a differentprovide.It's because the
rollupOptions.externalin Vite config pointed to../injectionKeys, but we sometime use the alias@/injectionKeys. So I simply usepath.resolveto be sureinjectionKeysare not bundled in custom components.