Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): avoid reseting the "selected" state on all field change - WF-155 #714

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

madeindjs
Copy link
Collaborator

@madeindjs madeindjs commented Dec 26, 2024

We want to disable the component "selected" state when the style of the component is changed (like when the user changes the background). But actually, this is done when any of evaluatedFields changes.

The fix was simply to run the behavior only when a "Style" field change. So I just tweaked a bit the watch source in ComponentProxy.

Screencast.From.2024-12-26.22-40-05.mp4

@madeindjs madeindjs self-assigned this Dec 26, 2024
@madeindjs madeindjs marked this pull request as ready for review January 2, 2025 08:28
…-155

We want to disable the component "selected" state when the style of the
component is changed (like when the user changes the background). But
actually, this is done when **any** of `evaluatedFields` changes.

The fix was simply to run the behavior only when a "Style" field change.
So I just tweaked a bit the `watch` source in `ComponentProxy`.
@ramedina86 ramedina86 merged commit db2b440 into writer:dev Jan 7, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants