chore(ui): improve icon fetching. WF-141 #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, glad to see the paths fixed too. Can you look into the merge conflict? it's a straightforward one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new component
ShareImgWithFallbackwhich takes an array of URLs for the image and uses the first successful URL.This component uses a new hook
useAssetContentTypethat takes care of fetching theContent-Typeheader of the asset URL, and handles the concurrency / cache. TheContent-Typeis needed because the server might serve a defaulttext/htmlif the assets doesn't exist.It also fix an edge case wherein the application run is an URL path like
https://streamsync-dev.osc-fr1.scalingo.io/hello/, we are trying to import asset from the root (https://streamsync-dev.osc-fr1.scalingo.io/) and not the path/helloI also took the opportunity to test the Vue.js component using Vue Test Utils
This change is transparent for the user.